Rust DoctorClippy · Correctness
Sort key closure returning unit
clippy::unit_return_expecting_ord
Return the sort key from the closure: a trailing semicolon makes it return unit.
- Category
- Correctness
- Default level
- warn
- Tier
- P1
- Producer
- Clippy
- Diff scope
- line
Not a defect when
There is effectively no such case: a closure returning unit gives every element the same key, so the sort or comparison silently does nothing.
What it reads
Clippy, with the compiler behind it. The only pass that compiles.
Tier
Serious: worth interrupting other work for.
The tier bounds how severe a rule may be; its category bounds the tier.Diff scope
The changed line itself.
What--scope contextual looks at to decide whether a change caused the finding.Change it
Turn it off, or make it blocking, without touching the code it flags:
rust-doctor --rule clippy::unit_return_expecting_ord=off .
rust-doctor --rule clippy::unit_return_expecting_ord=error .