Rust DoctorClippy · Correctness
Two assignments that were meant as a swap
clippy::almost_swapped
Use std::mem::swap: the second assignment reads the value the first one already overwrote.
- Category
- Correctness
- Default level
- warn
- Tier
- P1
- Producer
- Clippy
- Diff scope
- line
Not a defect when
Both places are meant to end up holding the same value (a deliberate copy, not a swap), in which case the second assignment is only redundant.
What it reads
Clippy, with the compiler behind it. The only pass that compiles.
Tier
Serious: worth interrupting other work for.
The tier bounds how severe a rule may be; its category bounds the tier.Diff scope
The changed line itself.
What--scope contextual looks at to decide whether a change caused the finding.Change it
Turn it off, or make it blocking, without touching the code it flags:
rust-doctor --rule clippy::almost_swapped=off .
rust-doctor --rule clippy::almost_swapped=error .